Skip to content

Various fixes#32

Merged
ndorin merged 8 commits into
mainfrom
various-fixes
May 22, 2026
Merged

Various fixes#32
ndorin merged 8 commits into
mainfrom
various-fixes

Conversation

@ndorin
Copy link
Copy Markdown
Contributor

@ndorin ndorin commented May 21, 2026

Closes #30

This pull request introduces a new export feature to the Debug Console, improves filtering and device labeling, and makes several minor code style and UI enhancements. The most notable update is the ability to export the currently filtered debug log to a file directly from the UI.

Debug Console Export Feature:

  • Added an "Export Log" button to the Debug Console UI, allowing users to export the currently filtered log messages to a .log file. The export includes timestamp, log level, optional key, and the rendered message for each log entry. The button is disabled if there are no filtered items. (DebugConsole.tsx) [1] [2]

Filtering and Device List Improvements:

  • Changed device sorting in the device filter dropdown to sort by device ID instead of device label, ensuring consistent ordering. (DebugFilters.tsx)
  • Updated device filter dropdown labels to include both the device name and its key (ID) for better clarity. (DeviceFilterDropdown.tsx)
  • Improved search tokenization in the shared filter component to ignore empty tokens, resulting in more accurate filtering. (FilterSearchText.tsx)

Code Style and Minor UI Improvements:

  • Standardized import statements to use single quotes for consistency across files. (DebugConsole.tsx, LoginForm.tsx) [1] [2]
  • Clarified a comment in the login form and fixed the order of loading state and error handling for better user feedback. (LoginForm.tsx) [1] [2]

@ndorin ndorin self-assigned this May 21, 2026
Copilot AI review requested due to automatic review settings May 21, 2026 22:48
@ndorin ndorin added bug Something isn't working enhancement New feature or request labels May 21, 2026
@ndorin ndorin requested a review from andrew-welker May 21, 2026 22:49
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses issue #30 by enhancing the Debug Console with an “Export Log” capability and improving filter usability (device ordering/labeling and search tokenization), alongside minor UI/code-style touch-ups.

Changes:

  • Added an “Export Log” button to export the currently filtered debug log to a .log file.
  • Improved filtering UX by sorting devices by ID and displaying device labels with their IDs.
  • Refined search tokenization to ignore empty tokens in URL-params mode.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/features/DebugConsole/DebugConsole.tsx Adds filtered-log export button and export implementation.
src/features/DebugConsole/DebugFilters.tsx Changes device dropdown ordering to sort by device ID.
src/features/DebugConsole/DeviceFilterDropdown.tsx Updates device checkbox labels to include the device ID.
src/shared/FilterSearchText.tsx Improves URL-param tokenization by removing empty tokens.
src/features/LoginForm.tsx Standardizes imports to single quotes and adjusts loading-state timing/comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/shared/FilterSearchText.tsx Outdated
Comment thread src/features/DebugConsole/DebugConsole.tsx Outdated
Comment thread src/features/DebugConsole/DeviceFilterDropdown.tsx Outdated
andrew-welker
andrew-welker previously approved these changes May 21, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 22, 2026 00:58
ndorin and others added 2 commits May 21, 2026 18:59
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Comment thread src/features/DebugConsole/DebugConsole.tsx
Comment thread src/features/DebugConsole/DeviceFilterDropdown.tsx
@ndorin ndorin requested a review from andrew-welker May 22, 2026 15:54
@ndorin ndorin merged commit 18afbe2 into main May 22, 2026
2 checks passed
@ndorin ndorin deleted the various-fixes branch May 22, 2026 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] In Debug Console - Download the debug session in progress

3 participants